Declaring types within the repos packages itself #2056
Conversation
joshstevens19
changed the title
|
Thank you for submitting this PR! I will have a close look on it later but I will definitely merge it into the ethereumProvider branch. But yes as you said it would be good to have typings for each package. Could you please add the missing last line to the type declaration of utils? and it would be also good to add this files to the |
|
Hey Nivida, thanks for the response i am glad you agree. Like i said once this one is merged in i will do a PR for every package :). This will be a huge step forward. So firstly there is no missing last line i forgot to remove the white space which i have done. Also by default npm brings all the files over unless they are in the Lastly i just seen a really nice way to export these types, as we do not have classes we can do what |
|
Hey just pushed my latest changes have a look and if happy merged in it and il get the other PRs to you when i get a chance. 1 PR per package 👍 cheers |
|
@joshstevens19 Great thanks! I thought it would be the better approach to define the files property in the package.json instead of ignoring all. It's much easier to just say what I would like to have in the NPM package instead of ignore anything I don't want to have in my NPM package. I've added the files property in all package.json files. I will resolve the conflicts and add your typings to the files property in the package.json. As you can see here: https://github.com/ethereum/web3.js/blob/ethereumProvider/packages/web3-utils/src/index.js#L33 I'm exporting the methods from the Utils file and all others too. It should be already possible to have imports like: |
|
Ok cool, I will resolve your comments when on a computer. In terms of what you said about only exporting what you need, yes I know we could already do it but in the TS world we would do that and we have no typing, so my point was whooop TypeScript devs can now import 1 function and have typing for it 👍 In terms of files in the NPM package - ok makes sense! Thanks il sort last comments a little later 👍 |
|
@joshstevens19 oh then I got you wrong I thought you were talking about the index.js. Yes, I agree with you it is better to export the types like this. Thanks for being so active! |
|
Pushed those changes up for you 👍 let me know if that's all good.. once this is merged in il go onto the next package and so on until all our complete. I may branch off after this merge so i can do many PRs at the same time (as we wont have any merge conflicts as they are different packages) |
Hi, i work with TypeScipt all the time and do use web3 constantly, i always find the types are well out of date and it just never keeps in sync. As per TypeScripts suggestion they state if possible putting your
d.tsfiles in the library itself gives a better user ability for the developers, as it will instantly expose the types. These are still all versioned with updates etc so you are getting a better developer experience.BigNumber.jsdo this as well as most big solutions which i think we should follow - https://github.com/MikeMcl/bignumber.js/blob/master/bignumber.d.tsWhat i have done is created the first
utils.d.tstypes for us in theweb3-utilspackage - i am planning to go through all the packages to expose these types so it's all in one repo if you approve of this PR. TypeScript only ever suggest using the@typesif you are not in-control of the repo - which we are.This solution will mean updating methods in the future and updating it's typing will be super easy for all the maintainers as it's in 1 repo. We can also add this to the contribution guidelines and pull request checklists meaning it will never be missed. I know a lot of people may just use
jsbut as a regularTSdeveloper using these library i think this would be a very good way to start improving this. Like i said i am happy to go through all of them and do a PR for eachpackage.The plan then would be once all types are in then we eventually remove type
@typespackage and everything installed with 1 command, or depreciate it on a certain version.It won’t make any difference to the way js developers work, it will still be
import * as Utils from 'web3-utils';but when doing that in a
.tsfile it will now expose all the typings allowing people to know the parameters types, return types etc!I have done this within the active
ethereumProviderbranch, but if you think it’s better suited for another branch let me know! 👍I see @nivida as the most active community member recently - take a look and let me know :)
Thanks
Josh